Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "read with streaming" unit-test (in network_spec.js) fails on the bots when run using the unittest command #7117

Closed
Snuffleupagus opened this issue Mar 26, 2016 · 3 comments
Labels

Comments

@Snuffleupagus
Copy link
Collaborator

As testing in PR #7116 shows, the "read with streaming" unit-test fails on the bots when run using the unittest command. However, the unit-test pass when run using the test command.

This issue thus seems to be identical to #6209 (comment), which means that we either need to use a locally available PDF file for that test, or change the unit-test framework to be able to deal with linked files.

/cc @brendandahl, @yurydelendik

@Snuffleupagus Snuffleupagus changed the title The "read with streaming" unit-test (in network_spec.js) fails on the bots when run using unittest command The "read with streaming" unit-test (in network_spec.js) fails on the bots when run using the unittest command Mar 26, 2016
@Snuffleupagus
Copy link
Collaborator Author

I've just submitted PR mozilla/botio-files-pdfjs#16 which should, once pushed to the bots, allow us to reference already downloaded linked PDF files in unit-tests.

Even with the bot patch, there would be one remaining issue. It's still required that e.g. browsertest is run in order for linked PDF files to actually be downloaded. Hence I've also submitted #7122, to make the unittest command able to deal with linked files as well.

@timvandermeij
Copy link
Contributor

Is this fixed by the two PRs above?

@Snuffleupagus
Copy link
Collaborator Author

Is this fixed by the two PRs above?

Yes, this is working as it should now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants