Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pdf_find_controller testing #7356

Closed
yurydelendik opened this issue May 25, 2016 · 1 comment
Closed

Add pdf_find_controller testing #7356

yurydelendik opened this issue May 25, 2016 · 1 comment
Labels
test viewer

Comments

@yurydelendik
Copy link
Contributor

We need to refactor and add PDFFindController unit tests. Currently it accepts PDFViewer however it uses only few methods to perform callbacks. It is recommended to remove dependency on PDFViewer, use only PDFDocument as source of the text content and generate events to update UI results.
@yurydelendik
Copy link
Contributor Author

(atm it's hard to add tests at #5579)

@timvandermeij timvandermeij mentioned this issue Sep 12, 2018
Merged
@timvandermeij timvandermeij mentioned this issue Sep 21, 2018
Merged
timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Jan 6, 2019
@timvandermeij
Write more unit tests for the find controller
42be612 
Fixes mozilla#7356.
@timvandermeij timvandermeij mentioned this issue Jan 6, 2019
Merged
timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Jan 12, 2019
@timvandermeij
Write more unit tests for the find controller
77e7357 
Fixes mozilla#7356.
timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Jan 12, 2019
@timvandermeij
Write more unit tests for the find controller
b1cef89 
Fixes mozilla#7356.
lpillonel pushed a commit to lpillonel/pdf.js that referenced this issue Jan 18, 2019
@timvandermeij @lpillonel
Write more unit tests for the find controller
d820a51 
Fixes mozilla#7356.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test viewer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yurydelendik