Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor scratch canvas usage #7798

Closed
yurydelendik opened this issue Nov 11, 2016 · 0 comments
Closed

Refactor scratch canvas usage #7798

yurydelendik opened this issue Nov 11, 2016 · 0 comments
Labels
feature other

Comments

@yurydelendik
Copy link
Contributor

At display/canvas.js, we create DOM canvas. It will be nice if we will be able to replace any DOM document.createElement('canvas') calls with some type of factory to allow it's replacement e.g. at the node.js apps. See also #7525 discussion.
@sandstrom sandstrom mentioned this issue Dec 25, 2016
Closed
@yurydelendik yurydelendik mentioned this issue Jan 4, 2017
Closed
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Jan 27, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
097d850
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Jan 27, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
e6d80e8 
Fixes extra canvas create call
@mukulmishra18 mukulmishra18 mentioned this issue Jan 27, 2017
Merged
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Jan 28, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
85c6f74 
Fixes extra canvas create call

removes unnecessary call of `new DOMCanvasFactory`.
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Jan 28, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
1bd3108 
Fixes extra canvas create call

removes unnecessary call of `new DOMCanvasFactory`.

Fixes undefined error of DOMCanvasFactory.
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Feb 1, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
0fce242 
Fixes extra canvas create call

removes unnecessary call of `new DOMCanvasFactory`.

Fixes undefined error of DOMCanvasFactory.

Fixes failures in some of the tests.
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Feb 2, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
02f1146 
Fixes extra canvas create calls.
Fixes unnecessary call of `new DOMCanvasFactory`.
Fixes undefined error of DOMCanvasFactory.
Fixes failures in some of the tests.
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Feb 4, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
4ed57dd 
Fixes extra canvas create calls.
Fixes unnecessary call of `new DOMCanvasFactory`.
Fixes undefined error of DOMCanvasFactory.
Fixes failures in some of the tests.

Fixes expected behaviour.
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Feb 4, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
efb4978 
Fixes extra canvas create calls.
Fixes unnecessary call of `new DOMCanvasFactory`.
Fixes undefined error of DOMCanvasFactory.
Fixes failures in some of the tests.
Fixes expected behaviour.

Remove unused vars.
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Feb 5, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
6edee09 
Fixes extra canvas create calls.
Fixes unnecessary call of `new DOMCanvasFactory`.
Fixes undefined error of DOMCanvasFactory.
Fixes failures in some of the tests.
Fixes expected behaviour.
Remove unused vars.
mukulmishra18 added a commit to mukulmishra18/pdf.js that referenced this issue Feb 5, 2017
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
3281763 
Fixes extra canvas create calls.
Fixes unnecessary call of `new DOMCanvasFactory`.
Fixes undefined error of DOMCanvasFactory.
Fixes failures in some of the tests.
Fixes expected behaviour.
Remove unused vars.
yurydelendik added a commit that referenced this issue Feb 6, 2017
@yurydelendik
Merge pull request #8002 from mukulmishra18/refactor-canvas
d842c9c 
[api-minor] Fix #7798: Refactor scratch canvas usage.
movsb pushed a commit to movsb/pdf.js that referenced this issue Jul 14, 2018
@mukulmishra18
Fix mozilla#7798: Refactor scratch canvas usage.
dc160a5 
Fixes extra canvas create calls.
Fixes unnecessary call of `new DOMCanvasFactory`.
Fixes undefined error of DOMCanvasFactory.
Fixes failures in some of the tests.
Fixes expected behaviour.
Remove unused vars.
movsb pushed a commit to movsb/pdf.js that referenced this issue Jul 14, 2018
@yurydelendik
Merge pull request mozilla#8002 from mukulmishra18/refactor-canvas
edd69ff 
[api-minor] Fix mozilla#7798: Refactor scratch canvas usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature other
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yurydelendik