Revert "Attempt to combine separate beginText/endText sequences in getTextContent (issue 9984)"
#10041
Conversation
…etTextContent` (issue 9984)"
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fdc624c6b20cd8f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/2a82194d65f7640/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/2a82194d65f7640/output.txt Total script time: 24.41 mins
Image differences available at: http://54.215.176.217:8877/2a82194d65f7640/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/fdc624c6b20cd8f/output.txt Total script time: 35.77 mins
Image differences available at: http://54.67.70.0:8877/fdc624c6b20cd8f/reftest-analyzer.html#web=eq.log |
|
I'll create an issue to look into why this is failing upstream, since I would like this functionality back, but I agree it's best to back it out for now so we can upstream. /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/162453ae271b3d2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3ca8d2c15af9dc4/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/162453ae271b3d2/output.txt Total script time: 22.26 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3ca8d2c15af9dc4/output.txt Total script time: 33.45 mins
|
| @@ -1546,7 +1535,6 @@ var PartialEvaluator = (function PartialEvaluatorClosure() { | |||
| task.ensureNotTerminated(); | |||
| timeSlotManager.reset(); | |||
| var stop, operation = {}, args = []; | |||
| let pendingBeginText = false; | |||
There was a problem hiding this comment.
Please note: This is actually a bug in the original PR, since this line should be placed e.g. just after https://github.com/mozilla/pdf.js/pull/10041/files#diff-0b94c2e77a5259f7a728122fdbf9f46aL1533 instead to ensure that pendingBeginText may never be accidentally reset.
Reverts #9986 for causing Mochitest failures, please refer to https://bugzilla.mozilla.org/show_bug.cgi?id=1488420#c2 and the following discussion.
/cc @timvandermeij
/cc @rvandermeulen