Implement unit tests for the isSameOrigin and createValidAbsoluteUrl utility functions and use the const keyword for constants in src/shared/util.js
#10061
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/37b6a56524605b2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/900d0f6ea27bf4c/output.txt |
timvandermeij
changed the title
isSameOrigin and createValidAbsoluteUrl utulity functions and use the const keyword for constants in src/shared/util.jsisSameOrigin and createValidAbsoluteUrl utility functions and use the const keyword for constants in src/shared/util.js
timvandermeij
force-pushed
the
unit-testing
branch
from
e362d96 to
16a8a5a
Compare
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/900d0f6ea27bf4c/output.txt Total script time: 24.69 mins
Image differences available at: http://54.215.176.217:8877/900d0f6ea27bf4c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/37b6a56524605b2/output.txt Total script time: 36.41 mins
|
…rl` utility functions Moreover, mark the `isValidProtocol` function as private since it's only used in the utilities file and is not (meant to be) exported.
Moreover, move general constants to the top of the file, i.e., those that are not closely tied to a function in the file.
timvandermeij
force-pushed
the
unit-testing
branch
from
16a8a5a to
bf13c8a
Compare
|
It turns out that the /botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f17e299397cd71d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8780f9538abf36d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f17e299397cd71d/output.txt Total script time: 5.28 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8780f9538abf36d/output.txt Total script time: 8.12 mins
|
This helps to increase test coverage of the
src/shared/util.jsfile.@Snuffleupagus Would you be willing to review this?