Normalize BBox of form XObjects in SVG back-end #10162
Conversation
|
Nice find! |
|
I think that would be unnecessary because the canvas back-end has no problems when BBox is unnormalized. |
Perhaps, but there's some value in having the API return data in a format that works directly in both back-ends without having to remember to transform it one of them, hence my question. |
|
I don't think there is a use case for needing an unnormalized bounding box, so I agree that it is probably better to handle this in core so any consumers don't need to worry about normalization anymore. |
janpe2
force-pushed
the
svg-normalize-bbox
branch
from
ed2356c to
9cd5f94
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e95ea9c212b3383/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/c2adc671feb7178/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/e95ea9c212b3383/output.txt Total script time: 6.65 mins
Image differences available at: http://54.67.70.0:8877/e95ea9c212b3383/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/c2adc671feb7178/output.txt Total script time: 24.02 mins
Image differences available at: http://54.215.176.217:8877/c2adc671feb7178/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/66aa03f63ede96c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/803a7856f1eeeee/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/803a7856f1eeeee/output.txt Total script time: 19.15 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/66aa03f63ede96c/output.txt Total script time: 23.99 mins
|
|
Nice work! |
In issue #10151, footnotes are missing because they are form XObjects that have unnormalized BBox entries, for example
/BBox [0.0 765.354 595.276 0.0]. This makes the height of SVG<rect>element negative, so the clipping path fails and the form XObject becomes invisible.This PR makes the footnote texts visible but some graphics are still missing because shadings haven't been implemented in the SVG back-end.