Ensure that matches are not scrolled into after the findbar has been closed (PR 10100 follow-up) #10184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to reduce the amount of event dispatching Given that dispatching the 'updatetextlayermatches' event with `pageIndex = -1` set is now used to target the textLayers of *all* pages, there's no need to send individual events to every single page during `_nextMatch`. Since there can be an arbitrary number of pages in a document, this small/simple optimization seems too easy to ignore.
…closed (PR 10100 follow-up) Despite all highlighted matches being removed in response to the 'findbarclose' event, there's a risk that a match could still be scrolled into view *after* the findbar has been closed[1]. Hence we need to ensure that long running searches, particularily those happening in large and/or slow loading documents[2], are ignored as well. --- [1] The match is hidden, as expected, but the document could still scroll unexpectedly. [2] Large documents loaded with `disableAutoFetch = true` and `disableStream = true` set are particularily susceptible to this issue.
Snuffleupagus
force-pushed
the
findbarclose-abort
branch
from
99b263f to
64d75c3
Compare
|
/botio-linux preview |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6e98403eec774b8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6e98403eec774b8/output.txt Total script time: 2.96 mins Published |
timvandermeij
approved these changes
Oct 28, 2018
|
Looks good; thank you! It's also good to see that the find code is becoming much more readable lately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that I noticed while testing PR #10183, and it probably deserves a separate PR rather than being lumped in with those changes since it's a direct follow-up to PR #10100.