Reduce the number of redundant updatetextlayermatches events dispatched when calculating matches in PDFFindController
#10201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ched when calculating matches in `PDFFindController` Currently `PDFFindController._calculateMatch` is (indirectly) dispatching an `updatetextlayermatches` event for every *single* page of the document. For short documents, such as the `tracemonkey` file, this probably doesn't matter too much, but for documents with a couple of thousand pages it seems unfortunate. It shouldn't be necessary, in general, to dispatch `updatetextlayermatches` events here, since that's already being taken care of in `PDFFindController._updateMatch` which is always called when a match has been found. However, when `highlightAll` is set we still need to ensure that pages which finished rendered *before* searching begun are updated correctly.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6664fadf086a53b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6664fadf086a53b/output.txt Total script time: 3.03 mins Published |
timvandermeij
approved these changes
Oct 31, 2018
|
Good optimization; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
PDFFindController._calculateMatchis (indirectly) dispatching anupdatetextlayermatchesevent for every single page of the document. For short documents, such as thetracemonkeyfile, this probably doesn't matter too much, but for documents with a couple of thousand pages it seems unfortunate.It shouldn't be necessary, in general, to dispatch
updatetextlayermatchesevents here, since that's already being taken care of inPDFFindController._updateMatchwhich is always called when a match has been found.However, when
highlightAllis set we still need to ensure that pages which finished rendered before searching begun are updated correctly.