Attempt to ignore mouse wheel zooming during tab switches (bug 1503412) #10351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch re-factors, and extends, the already existing `zoomDisabledTimeout` used during mouse wheel zooming. Unfortunately I haven't got the required hardware to actually test this patch, but there's a decent chance that it will fix, or at least reduce, the problems reported in https://bugzilla.mozilla.org/show_bug.cgi?id=1503412.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8e8098bcbdbfdb4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8e8098bcbdbfdb4/output.txt Total script time: 1.60 mins Published |
|
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9ded05bacc9c80f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/37568e78602d0c1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9ded05bacc9c80f/output.txt Total script time: 0.78 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/37568e78602d0c1/output.txt Total script time: 2.28 mins
|
timvandermeij
approved these changes
Dec 12, 2018
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch re-factors, and extends, the already existing
zoomDisabledTimeoutused during mouse wheel zooming.Unfortunately I haven't got the required hardware to actually test this patch, but there's a decent chance that it will fix, or at least reduce, the problems reported in https://bugzilla.mozilla.org/show_bug.cgi?id=1503412.