-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert src/core/chunked_stream.js
to ES6 syntax
#10376
Conversation
/botio-linux preview |
/botio test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good, thank you; but setting r- for the skip
method alone.
0fcac22
to
35cd49d
Compare
35cd49d
to
360c3d3
Compare
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2b7dbc9841d1b0b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2b7dbc9841d1b0b/output.txt Total script time: 1.66 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8f8cb896fa67864/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9181b1c2466c83a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8f8cb896fa67864/output.txt Total script time: 17.66 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9181b1c2466c83a/output.txt Total script time: 23.35 mins
|
While we're here, remove the unused
url
argument for theChunkedStreamManager
class that I found during the refactoring.@Snuffleupagus Would you be willing to review this? I found that GitHub can't apply the
?w=1
flag for the first commit for some reason, so here is the output ofgit show -w HEAD~1
: https://dpaste.de/vUQU