Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert src/core/chunked_stream.js to ES6 syntax #10376

Merged
merged 2 commits into from
Dec 25, 2018

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Dec 23, 2018

While we're here, remove the unused url argument for the ChunkedStreamManager class that I found during the refactoring.

@Snuffleupagus Would you be willing to review this? I found that GitHub can't apply the ?w=1 flag for the first commit for some reason, so here is the output of git show -w HEAD~1: https://dpaste.de/vUQU

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@timvandermeij
Copy link
Contributor Author

/botio test

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, thank you; but setting r- for the skip method alone.

@timvandermeij timvandermeij force-pushed the chunked-stream branch 2 times, most recently from 0fcac22 to 35cd49d Compare December 24, 2018 12:08
@mozilla mozilla deleted a comment from pdfjsbot Dec 24, 2018
@mozilla mozilla deleted a comment from pdfjsbot Dec 24, 2018
@mozilla mozilla deleted a comment from pdfjsbot Dec 24, 2018
@mozilla mozilla deleted a comment from pdfjsbot Dec 24, 2018
@mozilla mozilla deleted a comment from pdfjsbot Dec 24, 2018
@mozilla mozilla deleted a comment from pdfjsbot Dec 24, 2018
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2b7dbc9841d1b0b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/2b7dbc9841d1b0b/output.txt

Total script time: 1.66 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8f8cb896fa67864/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/9181b1c2466c83a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/8f8cb896fa67864/output.txt

Total script time: 17.66 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/9181b1c2466c83a/output.txt

Total script time: 23.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit d3868e1 into mozilla:master Dec 25, 2018
@timvandermeij timvandermeij deleted the chunked-stream branch December 25, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants