Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the for ... of loop from the PDFDocument.fingerprint getter (issue 10401) #10404

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Jan 3, 2019

It appears that the Symbol polyfill doesn't work well in conjunction with TypedArrays, and that part of PR #10393 is thus reverted.

Fixes #10401.

/cc @timvandermeij

…r (issue 10401)

It appears that the `Symbol` polyfill doesn't work well in conjunction with `TypedArray`s, and that part of PR 10393 is thus reverted.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Jan 3, 2019

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/565fb8b9f3ed0de/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 3, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/565fb8b9f3ed0de/output.txt

Total script time: 1.64 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jan 3, 2019

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/6a18131badec92d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 3, 2019

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/94eb8eeee0928d6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 3, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/6a18131badec92d/output.txt

Total script time: 17.70 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jan 3, 2019

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/94eb8eeee0928d6/output.txt

Total script time: 23.37 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 2d00bb0 into mozilla:master Jan 3, 2019
@timvandermeij
Copy link
Contributor

IE11 strikes again... Thank you for fixing this so quickly!

@Snuffleupagus Snuffleupagus deleted the issue-10401 branch January 4, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants