Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a settled property, tracking the fulfilled/rejected stated of the Promise, to createPromiseCapability #10515

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

This allows cleaning-up code which is currently manually tracking the state of the Promise of a createPromiseCapability instance.

…he Promise, to `createPromiseCapability`

This allows cleaning-up code which is currently manually tracking the state of the Promise of a `createPromiseCapability` instance.
@timvandermeij
Copy link
Contributor

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Feb 2, 2019

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f99ab662c13b09f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 2, 2019

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/9a252fd58676c3b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 2, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/f99ab662c13b09f/output.txt

Total script time: 2.61 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Feb 2, 2019

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/9a252fd58676c3b/output.txt

Total script time: 5.27 mins

  • Unit Tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Feb 2, 2019

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2858624dd14289d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 2, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/2858624dd14289d/output.txt

Total script time: 1.71 mins

Published

@timvandermeij timvandermeij merged commit 80495e6 into mozilla:master Feb 2, 2019
@timvandermeij
Copy link
Contributor

Thank you for this clean-up!

@Snuffleupagus Snuffleupagus deleted the createPromiseCapability-settled branch February 2, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants