Simplify the updatetextlayermatches event handling in TextLayerBuilder
#10554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder` This implements the nice suggestion from mozilla#10099 (comment), which I at the time didn't think would work. I'll probably have to plead temporary insanity here, since it *should* have been totally obvious to me how this could be implemented. By simply not registering the event until the `textLayer` is actually rendered, removing the event on `cancel` works just fine. This patch also removes the `pagecancelled` event, given that it's no longer used anywhere in the code-base and that its implemention was flawed since it wasn't guaranteed to be called in *every* situation where rendering was actually cancelled.
… artifacts when called directly
Currently these methods are only used from the respective `reset` methods, and from `{BaseViewer, PDFThumbnailViewer}._cancelRendering` which only runs when the active document is closed.
This patch changes `{PDFPageView, PDFThumbnailView}.cancelRendering` to *only* cancel any pending rendering operations, and doesn't attempt to reset e.g. the `renderingState`, since that causes visual glitches (duplicated canvases in the viewer) when called directly.
Furthermore, unless you "know" what you're doing, the `{PDFPageView, PDFThumbnailView}.reset` methods are what *should* normally be used instead.
Snuffleupagus
force-pushed
the
rendering-cancelled
branch
from
711b211 to
599dcf5
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e405071faa33be2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e405071faa33be2/output.txt Total script time: 1.77 mins Published |
timvandermeij
approved these changes
Feb 16, 2019
No worries! Thank you for simplifying the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the nice suggestion from #10099 (comment), which I at the time didn't think would work. @timvandermeij I'm sorry about that!
I'll probably have to plead temporary insanity here, since it should have been totally obvious to me how this could be implemented. By simply not registering the event until the
textLayeris actually rendered, removing the event oncancelworks just fine.This patch also removes the
pagecancelledevent, given that it's no longer used anywhere in the code-base and that its implemention was flawed since it wasn't guaranteed to be called in every situation where rendering was actually cancelled.