Ensure that the Cmd/Name/Ref caches are cleared when terminating the worker (PR 10863 follow-up)
#10873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
worker-terminate-clearPrimitiveCaches
branch
from
50caed6 to
cc163a0
Compare
…g the worker (PR 10863 follow-up) Usually when the worker is terminated it will also be completely destroyed/removed, which means that any global caches (such as the ones in `src/core/primitive.js`) should be automatically cleared in the process. However, for certain ways of loading the `pdf.worker.js` file, e.g. passing in a re-usable worker to `getDocument`, using the `workerPort` functionality, or even disabling workers completely (even though this is never a good idea), the worker file may be kept in memory and these caches will not be cleared as expected.
Snuffleupagus
force-pushed
the
worker-terminate-clearPrimitiveCaches
branch
from
cc163a0 to
a3742a9
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5d617e6c5acda0d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/86d689b280b19be/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5d617e6c5acda0d/output.txt Total script time: 17.84 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/86d689b280b19be/output.txt Total script time: 25.70 mins
|
timvandermeij
approved these changes
May 31, 2019
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually when the worker is terminated it will also be completely destroyed/removed, which means that any global caches (such as the ones in
src/core/primitive.js) should be automatically cleared in the process.However, for certain ways of loading the
pdf.worker.jsfile, e.g. passing in a re-usable worker togetDocument, using theworkerPortfunctionality, or even disabling workers completely (even though this is never a good idea), the worker file may be kept in memory and these caches will not be cleared as expected.