Make Dict handle all the fetching of Refs.

[brendandahl]

Now dict.get() will automatically deference refs. Not remembering to do xref.fetchIfRef has been the source of several bugs so hopefully this will help avoid that. I played around with doing this for Arrays too, but it proved to be a pretty large change, so I'll do that in another PR if I'm motivated (see # 1487 if you're interested in learning more).

Fixes #1447, #1370.

[yurydelendik]

@pdfjsbot test

[pdfjsbot]

Processing command test by user yurydelendik. Queue size: 2

Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4960933.txt

[bot:processed:4960933]

[brendandahl]

I broke links and TOC, don't merge yet.

[pdfjsbot]

ERROR(s) found

ATTENTION: There was a snapshot difference:
http://184.73.87.52:8989/tests/82a95d8bdefd5d4ae1486e895688ddb064623284/reftest-analyzer.xhtml#web=/tests/82a95d8bdefd5d4ae1486e895688ddb064623284/eq.log

Output:

========== Killing any stray processes

========== Running garbage collector in /mnt/pdfjsbot-tmp
Collecting garbage...

========== Cloning pull request repo
Cloning into ....

========== Merging upstream into pull request clone

========== Running 'make lint'
gjslint --nojsdoc  src/bidi.js src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metadata.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js    web/compatibility.js web/debugger.js web/viewer.js  test/driver.js  examples/helloworld/hello.js  extensions/firefox/bootstrap.js  extensions/firefox/components/PdfStreamConverter.js    test/unit/crypto_spec.js test/unit/font_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js
35 files checked, no errors found.

========== Cloning reference images repo into test/ref/
Initialized empty Git repository in /mnt/pdfjsbot-tmp/tests/82a95d8bdefd5d4ae1486e895688ddb064623284/test/ref/.git/

========== Checking for consistency with reference repo

========== Running 'make bot_test'
Xvfb: no process found
cd test; \
    python -u test.py \
    --browserManifestFile=resources/browser_manifests/browser_manifest.json \
    --manifestFile=test_manifest.json
Launching firefox
Launching chrome
TEST-PASS | eq test tracemonkey-eq | in chrome
TEST-PASS | eq test tracemonkey-eq | in firefox
TEST-PASS | forward-back-forward test tracemonkey-fbf | in chrome
TEST-PASS | load test html5-canvas-cheat-sheet-load | in chrome
TEST-PASS | forward-back-forward test tracemonkey-fbf | in firefox
TEST-PASS | load test html5-canvas-cheat-sheet-load | in firefox
TEST-PASS | eq test intelisa-eq | in chrome
TEST-PASS | eq test intelisa-eq | in firefox
TEST-PASS | load test pdfspec-load | in chrome
TEST-PASS | load test shavian-load | in chrome
TEST-UNEXPECTED-FAIL | eq sizes | in chrome | rendering of page 1 != reference rendering
TEST-PASS | eq test plusminus | in chrome
TEST-PASS | load test openoffice-pdf | in chrome
TEST-PASS | load test openofficecidtruetype-pdf | in chrome
TEST-PASS | load test openofficearabiccidtruetype-pdf | in chrome
TEST-PASS | load test arabiccidtruetype-pdf | in chrome
TEST-PASS | load test complexttffont-pdf | in chrome
TEST-PASS | eq test thuluthfont-pdf | in chrome
TEST-PASS | eq test freeculture | in chrome
TEST-PASS | eq test wnv_chinese-pdf | in chrome
TEST-PASS | eq test i9-pdf | in chrome
TEST-PASS | load test hmm-pdf | in chrome
TEST-PASS | eq test rotation | in chrome
TEST-PASS | load test ecma262-pdf | in chrome
TEST-PASS | load test jai-pdf | in chrome
TEST-PASS | eq test cable | in chrome
TEST-PASS | eq test pdkids | in chrome
TEST-UNEXPECTED-FAIL | eq artofwar | in chrome | rendering of page 1 != reference rendering
TEST-UNEXPECTED-FAIL | eq artofwar | in chrome | rendering of page 2 != reference rendering
TEST-UNEXPECTED-FAIL | eq artofwar | in chrome | rendering of page 3 != reference rendering
TEST-UNEXPECTED-FAIL | eq artofwar | in chrome | rendering of page 4 != reference rendering
TEST-PASS | load test pdfspec-load | in firefox
TEST-PASS | load test shavian-load | in firefox
TEST-PASS | eq test sizes | in firefox
TEST-PASS | eq test plusminus | in firefox
TEST-PASS | load test openoffice-pdf | in firefox
TEST-PASS | load test openofficecidtruetype-pdf | in firefox
TEST-PASS | load test openofficearabiccidtruetype-pdf | in firefox
TEST-PASS | load test arabiccidtruetype-pdf | in firefox
TEST-PASS | load test complexttffont-pdf | in firefox
TEST-PASS | eq test thuluthfont-pdf | in firefox
TEST-PASS | eq test wdsg_fitc | in chrome
TEST-PASS | eq test freeculture | in firefox
TEST-PASS | eq test unix01 | in chrome
TEST-PASS | eq test wnv_chinese-pdf | in firefox
TEST-PASS | eq test i9-pdf | in firefox
TEST-PASS | load test hmm-pdf | in firefox
TEST-PASS | eq test rotation | in firefox
TEST-PASS | eq test fit11-talk | in chrome
TEST-PASS | eq test fips197 | in chrome
TEST-PASS | load test txt2pdf | in chrome
TEST-PASS | load test f1040 | in chrome
TEST-PASS | load test hudsonsurvey | in chrome
TEST-PASS | eq test extgstate | in chrome
TEST-PASS | eq test usmanm-bad | in chrome
TEST-PASS | load test vesta-bad | in chrome
TEST-PASS | load test scan-bad | in chrome
TEST-PASS | load test ibwa-bad | in chrome
TEST-UNEXPECTED-FAIL | eq tcpdf_033 | in chrome | rendering of page 1 != reference rendering
TEST-PASS | eq test pal-o47 | in chrome
TEST-PASS | eq test simpletype3font | in chrome
TEST-PASS | eq test close-path-bug | in chrome
TEST-PASS | eq test alphatrans | in chrome
TEST-PASS | eq test devicen | in chrome
TEST-PASS | eq test cmykjpeg | in chrome
TEST-PASS | eq test protectip | in chrome
TEST-PASS | eq test piperine | in chrome
TEST-PASS | eq test issue840 | in chrome
TEST-PASS | eq test bpl13210 | in chrome
TEST-PASS | eq test tutorial | in chrome
TEST-PASS | eq test geothermal.pdf | in chrome
TEST-PASS | eq test lista_preliminar | in chrome
TEST-PASS | eq test issue919 | in chrome
TEST-PASS | eq test issue918 | in chrome
TEST-PASS | eq test issue1001 | in chrome
TEST-PASS | eq test aboutstacks | in chrome
TEST-PASS | eq test smaskdim | in chrome
TEST-PASS | eq test type4psfunc | in chrome
TEST-PASS | load test ocs | in chrome
TEST-PASS | eq test issue1010 | in chrome
TEST-PASS | load test ecma262-pdf | in firefox
TEST-PASS | eq test issue1015 | in chrome
TEST-UNEXPECTED-FAIL | eq issue1096 | in chrome | rendering of page 1 != reference rendering
TEST-PASS | eq test issue1127 | in chrome
TEST-PASS | load test issue1249-load | in chrome
TEST-PASS | load test liveprogramming | in chrome
TEST-PASS | eq test S2-eq | in chrome
TEST-PASS | eq test issue1055 | in chrome
TEST-PASS | eq test issue1169 | in chrome
TEST-PASS | eq test zerowidthline | in chrome
TEST-PASS | eq test html5checker | in chrome
TEST-PASS | eq test pdfkit_compressed | in chrome
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 1 != reference rendering
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 2 != reference rendering
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 3 != reference rendering
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 4 != reference rendering
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 5 != reference rendering
TEST-PASS | eq test preistabelle | in chrome
TEST-PASS | eq test issue1350 | in chrome
TEST-PASS | eq test issue925 | in chrome
TEST-PASS | eq test issue1133 | in chrome
TEST-PASS | eq test issue1049 | in chrome
TEST-PASS | eq test issue1155 | in chrome
TEST-PASS | eq test issue1002 | in chrome
TEST-PASS | eq test issue1243 | in chrome
TEST-PASS | eq test issue1257 | in chrome
TEST-PASS | eq test issue1309 | in chrome
TEST-PASS | eq test issue1317 | in chrome
TEST-PASS | load test jai-pdf | in firefox
TEST-PASS | eq test cable | in firefox
TEST-PASS | eq test pdkids | in firefox
TEST-PASS | eq test artofwar | in firefox
TEST-PASS | eq test wdsg_fitc | in firefox
TEST-PASS | eq test unix01 | in firefox
TEST-PASS | eq test fit11-talk | in firefox
TEST-PASS | eq test fips197 | in firefox
TEST-PASS | load test txt2pdf | in firefox
TEST-PASS | load test f1040 | in firefox
TEST-PASS | load test hudsonsurvey | in firefox
TEST-PASS | eq test extgstate | in firefox
TEST-PASS | eq test usmanm-bad | in firefox
TEST-PASS | load test vesta-bad | in firefox
TEST-PASS | load test scan-bad | in firefox
TEST-PASS | load test ibwa-bad | in firefox
TEST-PASS | eq test tcpdf_033 | in firefox
TEST-PASS | eq test pal-o47 | in firefox
TEST-PASS | eq test simpletype3font | in firefox
TEST-PASS | eq test close-path-bug | in firefox
TEST-PASS | eq test alphatrans | in firefox
TEST-PASS | eq test devicen | in firefox
TEST-PASS | eq test cmykjpeg | in firefox
TEST-PASS | eq test protectip | in firefox
TEST-PASS | eq test piperine | in firefox
TEST-PASS | eq test issue840 | in firefox
TEST-PASS | eq test bpl13210 | in firefox
TEST-PASS | eq test tutorial | in firefox
TEST-PASS | eq test geothermal.pdf | in firefox
TEST-PASS | eq test lista_preliminar | in firefox
TEST-PASS | eq test issue919 | in firefox
TEST-PASS | eq test issue918 | in firefox
TEST-PASS | eq test issue1001 | in firefox
TEST-PASS | eq test aboutstacks | in firefox
TEST-PASS | eq test smaskdim | in firefox
TEST-PASS | eq test type4psfunc | in firefox
TEST-PASS | load test ocs | in firefox
TEST-PASS | eq test issue1010 | in firefox
TEST-PASS | eq test issue1015 | in firefox
TEST-PASS | eq test issue1096 | in firefox
TEST-PASS | eq test issue1127 | in firefox
TEST-PASS | load test issue1249-load | in firefox
TEST-PASS | load test liveprogramming | in firefox
TEST-PASS | eq test S2-eq | in firefox
TEST-PASS | eq test issue1055 | in firefox
TEST-PASS | eq test issue1169 | in firefox
TEST-PASS | eq test zerowidthline | in firefox
TEST-PASS | eq test html5checker | in firefox
TEST-PASS | eq test pdfkit_compressed | in firefox
TEST-PASS | eq test tamreview | in firefox
TEST-PASS | eq test preistabelle | in firefox
TEST-PASS | eq test issue1350 | in firefox
TEST-PASS | eq test issue925 | in firefox
TEST-PASS | eq test issue1133 | in firefox
TEST-PASS | eq test issue1049 | in firefox
TEST-PASS | eq test issue1155 | in firefox
TEST-PASS | eq test issue1002 | in firefox
TEST-PASS | eq test issue1243 | in firefox
TEST-PASS | eq test issue1257 | in firefox
TEST-PASS | eq test issue1309 | in firefox
TEST-PASS | eq test issue1317 | in firefox

OHNOES!  Some tests failed!
  different ref/snapshot: 12
Process firefox is still running. Killing.
Runtime was 1417 seconds

========== Cleaning up
./run-test: line 206: 31246 Killed                  Xvfb :1 -screen 0 1280x1024x24 > /dev/null 2> /dev/null

All done.


_____________________________ stderr:

Bot response time: 72.07 mins

[yurydelendik]

good if #1493 merged