Tiling #19
Merged
Tiling #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
June 16, 2011 11:26
| @@ -2110,6 +2110,10 @@ var CanvasGraphics = (function() { | |||
| }, | |||
| setFillColorSpace: function(space) { | |||
| // TODO real impl | |||
| if (space.name === "Pattern") | |||
| this.colorspace = "Pattern"; | |||
There was a problem hiding this comment.
Call this "colorSpace" ("colorspace" isn't a word) and make it part of the CanvasExtraState.
|
Overall looks good. Let's fix up the nits and we'll get it merged. |
| // The following bug should allow us to remove this. | ||
| // https://bugzilla.mozilla.org/show_bug.cgi?id=664884 | ||
| // | ||
| // Also, larg numbers seem to cause overflow which causes |
There was a problem hiding this comment.
"large", but deleting this sentence it would be fine with me.
|
So I still wasnt sure about the symbolic constants, so I created a const array with the different types. Not sure if this is what you wanted. Otherwise, I think all the requested changes have been done. |
|
alright, it should be ready |
joneschrisg
added a commit
that referenced
this pull request
Jun 20, 2011
joneschrisg
added a commit
that referenced
this pull request
Jun 28, 2011
This was referenced Aug 13, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was planning to put tiling off until all of the stream infrastructure was done. I wanted to commit so that we don't end up duplicating work. There is still a bug in that the tiling is inversed, but otherwise it looks fine.