Reset #renderError on RenderingCancelledException (PR 19128 follow-up)
#19558
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/30838b47aaabccd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/30838b47aaabccd/output.txt Total script time: 0.87 mins Published |
Snuffleupagus
force-pushed
the
RenderingCancelledException-null-#renderError
branch
from
90addf6 to
6fae111
Compare
…w-up) This restores the behaviour that existed prior to PR 19128, see e.g. https://github.com/mozilla/pdf.js/blob/8727a04ae588545c8e954c143b9fc64384712461/web/pdf_page_view.js#L908-L911, since `RenderingCancelledException` should still overwrite any previously seen Error.
Snuffleupagus
force-pushed
the
RenderingCancelledException-null-#renderError
branch
from
6fae111 to
d50d3b0
Compare
nicolo-ribaudo
approved these changes
Feb 25, 2025
Snuffleupagus
deleted the
RenderingCancelledException-null-#renderError
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the behaviour that existed prior to PR #19128, see e.g.
pdf.js/web/pdf_page_view.js
Lines 908 to 911 in 8727a04
RenderingCancelledExceptionshould still overwrite any previously seen Error./cc @nicolo-ribaudo