Invoke TranslatedFont.prototype.loadType3Data only *once* per font
#19563
Conversation
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3db0f81fd5b3517/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/94246cef264cdbb/output.txt |
Currently we're first loading the font, and then for Type3 fonts we're invoking `loadType3Data` every time that the font is encountered. That seems completely unnecessary, and it's probably connected to the age of this code, since the `loadType3Data`-method will only run once anyway (note the caching).
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/94246cef264cdbb/output.txt Total script time: 2.48 mins
|
Snuffleupagus
force-pushed
the
loadType3Data-once
branch
from
5b311ef to
bdfa968
Compare
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3db0f81fd5b3517/output.txt Total script time: 7.98 mins
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6aea048e7b2d620/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0b114021f11f27b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6aea048e7b2d620/output.txt Total script time: 17.10 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0b114021f11f27b/output.txt Total script time: 30.55 mins
|
Currently we're first loading the font, and then for Type3 fonts we're invoking
loadType3Dataevery time that the font is encountered.That seems completely unnecessary, and it's probably connected to the age of this code, since the
loadType3Data-method will only run once anyway (note the caching).