Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using ICC profiles in using qcms #19564

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support using ICC profiles in using qcms #19564

wants to merge 1 commit into from
+943 −324

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/265341b40e3ee6f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b0bf3a5b07533fb/output.txt

@Snuffleupagus Snuffleupagus added core image-quality release-blocker Blocker for the upcoming release labels Feb 26, 2025
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b0bf3a5b07533fb/output.txt

Total script time: 30.14 mins

  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 215

Image differences available at: http://54.241.84.105:8877/b0bf3a5b07533fb/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/265341b40e3ee6f/output.txt

Total script time: 60.01 mins

@Snuffleupagus
Copy link
Collaborator

The Node.js test failures can probably be fixed by adding a line for qcms, similar to:

pdf.js/gulpfile.mjs

Line 1658 in da17c7b

gulp.src("external/openjpeg/*.js", { base: "openjpeg/", encoding: false }),

Looking at the Linux reference tests there's bunch of small movement (invisible to the naked eye), or changes that are obvious improvements (when comparing with Adobe Reader), however there's also two actual regressions:

  • issue5939-page1
  • kdchart-page1

Snuffleupagus
Snuffleupagus reviewed Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a few unsolicited questions/comments, despite this still being a draft.

external/qcms/qcms_pdf_js.js Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this directory also have relevant LICENSE file(s), similar to e.g. https://github.com/mozilla/pdf.js/tree/master/external/openjpeg?

@Snuffleupagus Snuffleupagus linked an issue Feb 27, 2025 that may be closed by this pull request
ICC profiles support for images #2856
Open
@calixteman calixteman force-pushed the qcms_icc branch 2 times, most recently from 22b9791 to 7d50496 Compare February 27, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus left review comments

Assignees
No one assigned
Labels
core image-conversion image-quality release-blocker Blocker for the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICC profiles support for images
3 participants
@calixteman @moz-tools-bot @Snuffleupagus