Change PDFImage to use ColorSpace.parseAsync
#19570
Closed
+91
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the `ColorSpace` parsing happens in the constructor we cannot just await it, which required a slightly more complicated solution (without having to attempt a full re-write of this class). In particular the final parsing in the constructor will now wait for the `ColorSpace` parsing before completing, and the already asynchronous `createImageData`-method (which all images need to use) will ensure that all images are completely initialized.
Snuffleupagus
force-pushed
the
PDFImage-ColorSpace-parseAsync
branch
from
cdc7570 to
0f3d384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
ColorSpaceparsing happens in the constructor we cannot just await it, which required a slightly more complicated solution (without having to attempt a full re-write of this class).In particular the final parsing in the constructor will now wait for the
ColorSpaceparsing before completing, and the already asynchronouscreateImageData-method (which all images need to use) will ensure that all images are completely initialized.Smaller diff with https://github.com/mozilla/pdf.js/pull/19570/files?w=1