Hack to support automatic printing from pdf javascript.

[brendandahl]

https://bugzilla.mozilla.org/show_bug.cgi?id=843342

[yurydelendik]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/d98bf63866783c1/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/0d5f766b0cfa9dd/output.txt

[yurydelendik]

/botio-windows preview

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_preview from @yurydelendik received. Current queue size: 2

Live output at: http://107.22.172.223:8877/77b71818b8024aa/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/d98bf63866783c1/output.txt

Total script time: 19.83 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/0d5f766b0cfa9dd/output.txt

Total script time: 19.87 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/77b71818b8024aa/output.txt

Total script time: 0.25 mins

Published

• Viewer: http://107.22.172.223:8877/77b71818b8024aa/web/viewer.html
• Extension: http://107.22.172.223:8877/77b71818b8024aa/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.22.172.223:8877/77b71818b8024aa/extensions/firefox/pdf.js.amo.xpi

[yurydelendik]

Getting error when opening and printing https://bugzilla.mozilla.org/attachment.cgi?id=716808:

 --
[20:18:06.081] TypeError: self.displayReadyPromise is undefined @ resource://pdf.js/build/pdf.js:1640

I think we shall wait for rendering visible pages to be completed before showing print dialog. Also will help user to cancel the printing, if wrong pdf was opened by accident.

[jviereck]

should we call window.print only if printing is supported in the browser (e.g. not in chrome)?

[brendandahl]

Should we be checking for .print( rather than just print(?

print() is on the global object and I've seen a real world case of just "print(true);"

should we call window.print only if printing is supported in the browser (e.g. not in chrome)?

Yes, good point.

[brendandahl]

/botio-windows preview

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_preview from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/bfb1cd99022c844/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/bfb1cd99022c844/output.txt

Total script time: 0.28 mins

Published

• Viewer: http://107.22.172.223:8877/bfb1cd99022c844/web/viewer.html
• Extension: http://107.22.172.223:8877/bfb1cd99022c844/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.22.172.223:8877/bfb1cd99022c844/extensions/firefox/pdf.js.amo.xpi

[yurydelendik]

Looks good

[JamesMGreene]

What release version of PDF.js will have this fix? Looks like you guys haven't had a release cut (on GitHub) in almost a year but the orginally referenced bug states that the fix is in Firefox 20b5 and above.

[yurydelendik]

What release version of PDF.js will have this fix?

0.8.1 at https://addons.mozilla.org/en-US/firefox/addon/pdfjs/

but the orginally referenced bug states that the fix is in Firefox 20b5 and above

target milestone for the referenced bug Firefox 22

[JamesMGreene]

@yurydelendik Can you please explain what a "target milestone" actually means? Does that mean that the fix wasn't actually integrated/released until Firefox 22 despite having been tested and verified in earlier versions?

Thanks!

[yurydelendik]

okay, reading comments in the bug, it's available in firefox 20 and 21 as well, so it was uplifted.

[JamesMGreene]

OK, thanks. If I can bother you with one more slightly unrelated question: all the search results I'm finding on Google suggest that PDF Viewer (pdf.js) should just come integrated as the default PDF viewing application in the more recent versions of Firefox. However, it was not present in my FF22 installation, and this repo's README also suggests that you have to install the separate extension.

Was there some brief period (perhaps the FF19 release?) where pdf.js was integrated as the default, but then removed in subsequent versions?

[yurydelendik]

@JamesMGreene pdf.js was not removed after release in firefox 19. looks like you disabled it somehow. try create a new profile. but you can install the extension

[JamesMGreene]

Weird. Thanks for your help!