-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fake name table to works with Firefox trunk #30
Conversation
…ing the page in an infinite loop
… (Mozilla bug 660088)
…imetype and fix a few more 'strict mode' errrors
…ry (note TrueType still fails on cmap)
Also those commits fix the positioning problem of the '+' sign in the header of the document. |
maxp = [], // Maximum profile | ||
name = [], // Naming tables | ||
post = []; // PostScript informations | ||
OS2 = [], // OS/2 and Windows Specific metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why create an empty array here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no good reason for it, I think i have wanted to have a place where all the required tables names are visible in one shot. I can remove that if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant we make [] arrays here. Having the names is fine, but the [] is just dead weight.
I have addressed most of the comments you made with the last commit and I have removed the TrueType class and merge in the Font code so it will be much easier to maintain, I have also removed the 'a' prefix before arguments since people tend to think it's ugly ;) |
Add a fake name table to works with Firefox trunk
Add a fake name table to works with Firefox trunk
The code also embed some of my latest changes for TrueType, but this is still disabled since it's not working on all files and I need to update the TrueType code to works with the last refactor...