issue #3346: Text Selection Example

[vivin]

Text selection example.

[yurydelendik]

@vivin , can you change your example to use extracted text_layer_builder.js?

[vivin]

@yurydelendik Will do so! I will try and get to it this weekend.

[vivin]

@yurydelendik I've updated the example. I tested it out and it seems to work. Hope it's good to go!

[mitar]

How much this code depend on viewer.js? I see that it depends on find bar?

[vivin]

@mitar, PDFFindBar is not necessary, and TexLayerBuilder will work without it. I added in this case because viewer.js requires it.

[mitar]

I am just saying that it is useful to have clean and small examples. :-)

[vivin]

@mitar Oh, of course. I hope I didn't come across as rude. Was only trying to clarify. :)

[mitar]

:-) No problem. The issue is that we tried to implement text selection just few days ago. And we had to copy-paste some code from viewer.js to make it work. Why is not text selection code completely independent from viewer.js? There is text_layer_builder.js, but it is not enough. Our code we ended up using.

[vivin]

@mitar, The text selection code is actually independent from viewer.js. What was't working for you when you used it? You can simply use text_layer_builder.js as is, because what you pass into the constructor are references to PDFFindBar and PDFFindController, and if those aren't passed in, TextLayerBuilder doesn't use them.

[mitar]

I am not sure. It was done by a teammate. @speigg, can you fill us in here? Why was text_layer_builder.js not enough?

[vivin]

@mitar I think you will need ui_utils.js as well. I forgot about that. :)

[speigg]

Yes, some code from ui_uitls.js was also needed

[mitar]

@speigg, OK, then no need for us to merge this into one file, but could just add two separate files. It is easier to track this then.

[mitar]

Yes, text_layer_builder.js and ui_uitls.js is enough.

[timvandermeij]

@vivin What is the status of this PR?

[vivin]

Still waiting for a merge. Hope they haven't forgotten about it. :)

[timvandermeij]

In that case, @yurydelendik might know more. :-)

[Snuffleupagus]

It might be a good idea to squash the commits in this PR, to keep the commit history cleaner.

[yurydelendik]

Could you remove extra spaces near 'class=' ?

[vivin]

Hey Yury!

Will make the changes as soon as I can and squash.

[brendandahl]

Any updates on this?

[vivin]

Sorry, was caught up with work! I will try and get to this today.

[vivin]

Commits have been squashed. Should be ok to merge.

[yurydelendik]

Thank you for the patch

[vivin]

@yurydelendik Glad to help! :)

[apoku]

Just noticed this example recently underwent a complete re-write. I had a functional version working with the old example (just mis-aligned text issue I am working through). Is there significant or notable changes in the latest example?

Here is the commit I am referring to:
513a3d8

[yurydelendik]

@apoku please open a separate issue for that an specify more information. Shortly, #5552 creates a better way to handle the painting of the entire page (including canvas, text layer and annotation). You may still use TextLayerBuilder (but it's really hard to tell since you did not provide any code you are refrerring to).

[apoku]

Thanks @yurydelendik, your short explanation is perfectly sufficient--I was just wanting to understand conceptually what that re-write encompassed.