Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't traverse cyclic references in Dict.getAll; reduces empty-Dict GC #4374

Merged
merged 1 commit into from
Apr 8, 2014
Merged

Doesn't traverse cyclic references in Dict.getAll; reduces empty-Dict GC #4374

merged 1 commit into from
Apr 8, 2014

Conversation

yurydelendik
Copy link
Contributor

As a side effect, all Dict objects will have PDF object IDs -- shall help with debugging and preventing future cyclic references problems

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2014

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.22.172.223:8877/12da813a5c350db/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2014

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/05095be932c2408/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2014

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/05095be932c2408/output.txt

Total script time: 25.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2014

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/12da813a5c350db/output.txt

Total script time: 36.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/12da813a5c350db/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij mentioned this pull request Mar 3, 2014
Closed
@timvandermeij
Copy link
Contributor

Probably fixes #4370.

@timvandermeij
Copy link
Contributor

@yurydelendik Could you rebase this?

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f3a60b1cddae51e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c829a39a690bde7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/f3a60b1cddae51e/output.txt

Total script time: 25.72 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/c829a39a690bde7/output.txt

Total script time: 36.43 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

Is this good to go?

brendandahl added a commit that referenced this pull request Apr 8, 2014
@brendandahl
Merge pull request #4374 from yurydelendik/dictgetall
608c6ce 
Doesn't traverse cyclic references in Dict.getAll; reduces empty-Dict GC
@brendandahl brendandahl merged commit 608c6ce into mozilla:master Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandahl brendandahl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yurydelendik @pdfjsbot @timvandermeij @brendandahl