-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JPX colors #4397
Fix JPX colors #4397
Conversation
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/488c5e4fbe81648/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/488c5e4fbe81648/output.txt Total script time: 0.35 mins Published
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/89ca644256154a3/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/fbc896e7ce9f5dc/output.txt |
Linux tests failed. Reference images are here: http://107.21.233.14:8877/fbc896e7ce9f5dc/reftest-analyzer.html#web=eq.log (Tracking missing Linux bot messages at #4389) |
Yes, they failed because the colors were wrong, and now they are correct. |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/89ca644256154a3/output.txt Total script time: 35.64 mins
Image differences available at: http://107.22.172.223:8877/89ca644256154a3/reftest-analyzer.html#web=eq.log |
@fkaelberer really nice (can you reword the commit message? :) |
Done ;-) To reproduce the issue that is fixed, create a pdf file from |
/cc @notmasteryet |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7b54867ebb3dd9c/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5c16d8c68186243/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/5c16d8c68186243/output.txt Total script time: 25.09 mins
Image differences available at: http://107.21.233.14:8877/5c16d8c68186243/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/7b54867ebb3dd9c/output.txt Total script time: 35.58 mins
Image differences available at: http://107.22.172.223:8877/7b54867ebb3dd9c/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5b412336a19d6d4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c7224737b76f3b9/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/c7224737b76f3b9/output.txt Total script time: 34.97 mins
|
Thank you for the pull request |
Puh, finally. That was a tough one, because there were two independent issues.
Fixes the color/contrast issues reported in #3561 and #4358.
Colors of #2790 and #3181 are also good now.