Fix coding style in /web #4424
Merged
Fix coding style in /web #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Snuffleupagus Looks good to me when those two nits are addressed. |
|
I fixed the nits. Please look through all the changes one more time before merging, I'd really like to avoid regressing anything! |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/28d4d47cb356298/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/28d4d47cb356298/output.txt Total script time: 0.36 mins Published
|
timvandermeij
added a commit
that referenced
this pull request
Mar 10, 2014
Fix coding style in /web
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly adds braces to single line statements, and it also fixes a few indentation errors.
@timvandermeij Unfortunately this isn't covered by the tests, so you will have to go through it very carefully line by line. Sorry about that!
I've tested this PR by using the viewer when browsing through a few PDFs, but please test this too. (E.g. check that text selection and searching works as before.)