Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making extensions/chromium/*.js adhere to the style guide #4426

Merged

Conversation

timvandermeij
Copy link
Contributor

@Snuffleupagus I apologize in advance because this might be hard to review. Most files (especially chrome.tabs.executeScriptInFrame.js) were indented in a different way than in the style guide, so fixing that causes the diff here to be hard to parse. It might be easier to just use the View button for some files and go through the files to see if all is correct.

It would be nice if you could compile the Chrome extension and test it to make sure nothing is broken.

@Rob--W
Copy link
Member

Rob--W commented Mar 11, 2014

No functional changes, +1 from me.

To make reviewing a bit easier, just add ?w=1 to the URL, to ignore whitespace:
https://github.com/mozilla/pdf.js/pull/4426/files?w=1

@brendandahl
Copy link
Contributor

Maybe I missed something on IRC, are we trying to get it so we run jshint with the 'curly' option?

@timvandermeij
Copy link
Contributor Author

@brendandahl Yes. It's mostly to make the codebase itself adhere to the style guide, but a useful side effect is that we can hopefully enforce the curly option in jshint to make sure the codebase stays in line with the style guide and to avoid unnecessary review comments.

Snuffleupagus added a commit that referenced this pull request Mar 14, 2014
Making extensions/chromium/*.js adhere to the style guide
@Snuffleupagus Snuffleupagus merged commit ba8a590 into mozilla:master Mar 14, 2014
@timvandermeij timvandermeij deleted the extensions-chromium-syntax branch March 14, 2014 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants