-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes pages without Resources in their dictionary #4464
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/00f5c4e40dfeb07/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/5d169597363e138/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/00f5c4e40dfeb07/output.txt Total script time: 25.89 mins
|
Looks good with test from #4461 included with reftests as 'load' test (since it's legal pdf). |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/5d169597363e138/output.txt Total script time: 37.29 mins
|
Improved the comment and removed the nit |
(e.g. see 8f3b198 as an example where a "load" test was added) |
Ahh, I didn't understand that you want me to add the test ;) |
…fail to load When no "\Resource" entry could be found return an empty dictionary
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/61ea381a697f8bf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/1e5352ca391e33b/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/61ea381a697f8bf/output.txt Total script time: 25.75 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/1e5352ca391e33b/output.txt Total script time: 37.35 mins
|
Fixes pages without Resources in their dictionary
Thank you for the patch |
Fix Issue #4461: Pages without \Resources in their dictionary fail to load
When no "\Resource" entry could be found return an empty dictionary
And when I am touching core.js anyway, also refactor and fix the style of
Page