Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coding style in src/core/fonts.js #4503

Merged
merged 1 commit into from
Mar 22, 2014
Merged

Fix coding style in src/core/fonts.js #4503

merged 1 commit into from
Mar 22, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/453aa17e57808a6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/7a4b530c7fcc163/output.txt

@timvandermeij
Copy link
Contributor

Code reviewed, looks really good. Let's await the test results.

@timvandermeij
Copy link
Contributor

I'm going to work on src/core/evaluator.js. Is that fine with you?

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/453aa17e57808a6/output.txt

Total script time: 25.05 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/7a4b530c7fcc163/output.txt

Total script time: 36.05 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/7a4b530c7fcc163/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/79f216a311549e2/output.txt

@Snuffleupagus
Copy link
Collaborator Author

I'm thinking that the test failures on Windows might be caused by a Firefox update on the bot. Let's hold off on testing (and obviously merging), until we have sorted out the failures!

I'm going to work on src/core/evaluator.js. Is that fine with you?

Sure!
I'll look at a few of the other remaining files in src/core/.

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/79f216a311549e2/output.txt

Total script time: 36.01 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/79f216a311549e2/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/949f934506acbfb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/bd92a84c0e020fa/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/949f934506acbfb/output.txt

Total script time: 25.09 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/bd92a84c0e020fa/output.txt

Total script time: 36.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Mar 22, 2014
Fix coding style in src/core/fonts.js
@timvandermeij timvandermeij merged commit 8355b51 into mozilla:master Mar 22, 2014
@Snuffleupagus Snuffleupagus deleted the fonts-braces branch March 22, 2014 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants