-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coding style in src/core/fonts.js #4503
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/453aa17e57808a6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7a4b530c7fcc163/output.txt |
Code reviewed, looks really good. Let's await the test results. |
I'm going to work on |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/453aa17e57808a6/output.txt Total script time: 25.05 mins
|
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/7a4b530c7fcc163/output.txt Total script time: 36.05 mins
Image differences available at: http://107.22.172.223:8877/7a4b530c7fcc163/reftest-analyzer.html#web=eq.log |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/79f216a311549e2/output.txt |
I'm thinking that the test failures on Windows might be caused by a Firefox update on the bot. Let's hold off on testing (and obviously merging), until we have sorted out the failures!
Sure! |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/79f216a311549e2/output.txt Total script time: 36.01 mins
Image differences available at: http://107.22.172.223:8877/79f216a311549e2/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/949f934506acbfb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/bd92a84c0e020fa/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/949f934506acbfb/output.txt Total script time: 25.09 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/bd92a84c0e020fa/output.txt Total script time: 36.11 mins
|
Fix coding style in src/core/fonts.js
/cc @timvandermeij