[Firefox] Stop importing default_preferences.js as a module and include it instead #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
added a commit
that referenced
this pull request
Mar 26, 2014
…references [Firefox] Stop importing default_preferences.js as a module and include it instead
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this thread, started by @nnethercote on dev.platform: https://groups.google.com/forum/#!topic/mozilla.dev.platform/sAuhWQOAWic.
This PR makes use of the preprocessor to include the file default_preferences.js, instead of loading it as a module in the
MOZCENTRAL/FIREFOXbuilds.The only way to test this is unfortunately to apply the patch, run
node make {mozcentral, firefox}, and then check thatDEFAULT_PREFERENCESis included properly ininitializeDefaultPreferences(i.e. lines https://github.com/mozilla/pdf.js/blob/master/web/default_preferences.js#L23-L27 should appear) in the following files:MOZCENTRAL- build/mozcentral/browser/extensions/pdfjs/content/PdfJs.jsm.FIREFOX- build/firefox/bootstrap.js.Note that the file default_preferences.js should not be present in the build directories, since it's no longer necessary.