Force default icon size for Text annotations without appearance stream #4520
Conversation
| @@ -21,6 +21,8 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| var DEFAULT_ICON_WIDTH = 22; | |||
| var DEFAULT_ICON_HEIGHT = 18.25; | |||
There was a problem hiding this comment.
Our icons are defined as squares 64x64 or 40x40. We probably need to make it a square here too
|
okay, trying to find PDFs where annotations without AP to test the theory |
|
From what I've seen, Reader only ignores /Rect for Text annotations that use a standard icon (no AP). An idea would be to force the annotation's size to fit the icon's here: https://github.com/mozilla/pdf.js/blob/master/src/shared/annotation.js#L625 |
timvandermeij
changed the title
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/be047d68d835ea7/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/be047d68d835ea7/output.txt Total script time: 0.38 mins Published
|
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/69d67063e628ccc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/d50d8c486a9156d/output.txt |
timvandermeij
changed the title
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d50d8c486a9156d/output.txt Total script time: 21.97 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/69d67063e628ccc/output.txt Total script time: 25.89 mins
|
Force default icon size for Text annotations without appearance stream
|
Looks good, thanks! |
Fixes #3998.