Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid drawing text when the font size is zero (issue 4484) #4535

Merged
merged 1 commit into from
Apr 2, 2014
Merged

Avoid drawing text when the font size is zero (issue 4484) #4535

merged 1 commit into from
Apr 2, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #4484.

Note that the code to update the textLayer is needed to prevent errors from TextLayerBuilder. It might be better to re-factor TextLayerBuilder to avoid this, but that seemed out of scope for this particular issue.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/72ee579afb1d5bb/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/225a681ba7ed856/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/6a9322df91acfa6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/6a9322df91acfa6/output.txt

Total script time: 21.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/225a681ba7ed856/output.txt

Total script time: 25.63 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/225a681ba7ed856/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c1bb663daf640d3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/c1bb663daf640d3/output.txt

Total script time: 25.56 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

/botio-linux lint

@pdfjsbot
Copy link

pdfjsbot commented Apr 2, 2014

From: Bot.io (Linux)


Received

Command cmd_lint from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/33b64d9f8d531af/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 2, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/33b64d9f8d531af/output.txt

Total script time: 0.65 mins

  • Lint: Passed

yurydelendik added a commit that referenced this pull request Apr 2, 2014
Avoid drawing text when the font size is zero (issue 4484)
@yurydelendik yurydelendik merged commit dc0e60d into mozilla:master Apr 2, 2014
@Snuffleupagus Snuffleupagus deleted the issue-4484 branch April 2, 2014 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First page of PDF shows momentarily and then goes away
4 participants