-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid drawing text when the font size is zero (issue 4484) #4535
Conversation
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/72ee579afb1d5bb/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/72ee579afb1d5bb/output.txt Total script time: 0.41 mins Published
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/225a681ba7ed856/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/6a9322df91acfa6/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/6a9322df91acfa6/output.txt Total script time: 21.11 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/225a681ba7ed856/output.txt Total script time: 25.63 mins
Image differences available at: http://107.21.233.14:8877/225a681ba7ed856/reftest-analyzer.html#web=eq.log |
/botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c1bb663daf640d3/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c1bb663daf640d3/output.txt Total script time: 25.56 mins
|
/botio-linux lint |
From: Bot.io (Linux)ReceivedCommand cmd_lint from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/33b64d9f8d531af/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/33b64d9f8d531af/output.txt Total script time: 0.65 mins
|
Avoid drawing text when the font size is zero (issue 4484)
Fixes #4484.
Note that the code to update the
textLayer
is needed to prevent errors fromTextLayerBuilder
. It might be better to re-factorTextLayerBuilder
to avoid this, but that seemed out of scope for this particular issue.