Use new Chromium APIs for FTP and redirects #4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://crbug.com/280464 has been resolved, so we can now use redirectUrl at onHeadersReceived. For backwards-compatibility, the code for the original method has not been removed, and a feature detection script was added that detects whether the desired feature is available.
|
Looks good, thanks |
yurydelendik
added a commit
that referenced
this pull request
Apr 2, 2014
Use new Chromium APIs for FTP and redirects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Chromium 35, extensions can get the content of ftp URLs using XMLHttpRequests.
Starting with Chromium 35, extensions can redirect requests after detecting the (PDF) MIME-type. With this feature, PDFs in frames can reliably be redirected to the viewer URL.
For both features, I've added capability tests to ensure full backwards compatibility.