Prevent the Document Properties from being empty when the dialog is opened before the file has started loading

[Snuffleupagus]

Currently when opening the Document Properties during file load, all fields will remain blank, with the following message printed in the console: TypeError: PDFView.pdfDocument is null.

This PR adds a promise that is resolved when the data is available, and also re-factors the code slightly to add a updateUI function so that the file size is updated once it's available.

/cc @timvandermeij

[Snuffleupagus]

/botio-windows preview

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/662ae9e033480cb/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/662ae9e033480cb/output.txt

Total script time: 0.49 mins

Published

• Viewer: http://107.22.172.223:8877/662ae9e033480cb/web/viewer.html
• B2G Viewer: http://107.22.172.223:8877/662ae9e033480cb/extensions/b2g/content/web/viewer.html
• Extension: http://107.22.172.223:8877/662ae9e033480cb/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.22.172.223:8877/662ae9e033480cb/extensions/firefox/pdf.js.amo.xpi

[timvandermeij]

I cannot replicate the TypeError, but I do notice that the dialog stays blank until you open it again. With your version, the dialog is indeed updated once the file has been loaded, so I think that's better behaviour for the dialog.

[Snuffleupagus]

I cannot replicate the TypeError

It can be tricky to reproduce, since it requires that you manage to open the Document Properties after the viewer itself is loaded, but before the PDF file has begun loading.

With your version, the dialog is indeed updated once the file has been loaded, so I think that's better behaviour for the dialog.

So, is this PR good to go then? :-)

[yurydelendik]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8be769121390b00/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/8be769121390b00/output.txt

Total script time: 0.42 mins

Published

• Viewer: http://107.21.233.14:8877/8be769121390b00/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/8be769121390b00/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/8be769121390b00/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.21.233.14:8877/8be769121390b00/extensions/firefox/pdf.js.amo.xpi

[yurydelendik]

Thanks