Use Opaque Canvas #4556
Use Opaque Canvas #4556
Conversation
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/16bac150d351134/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/16bac150d351134/output.txt Total script time: 0.42 mins Published
|
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/752af7e2d4c355f/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d0c63ba7f63fb5b/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/752af7e2d4c355f/output.txt Total script time: 21.88 mins
Image differences available at: http://107.22.172.223:8877/752af7e2d4c355f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/d0c63ba7f63fb5b/output.txt Total script time: 25.68 mins
Image differences available at: http://107.21.233.14:8877/d0c63ba7f63fb5b/reftest-analyzer.html#web=eq.log |
|
Hm, this really seems to break a lot. Any ideas? |
|
I'm guessing this is relevant: https://github.com/mozilla/pdf.js/blob/master/src/display/canvas.js#L678 |
|
@p01 Could you squash these commits into one? |
|
Done. Every PDF I checked from the previous test run passes now. |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/62820354091e7a9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/19054be7e059b19/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/19054be7e059b19/output.txt Total script time: 21.32 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/62820354091e7a9/output.txt Total script time: 25.38 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c337ba459345a4c/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c337ba459345a4c/output.txt Total script time: 0.42 mins Published
|
|
Thanks |
|
Reverted the patch by f6c631b due to heavy while->black->white flickering on Chrome browser. Needs some work. |
This improves painting performance and text rendering quality in some browsers, without any measurable performance impact.
Scrolling through the TraceMonkey PDF, several times, at three different zoom level with and without opaque Canvas, the average time to draw a page was the same in both Firefox Aurora and Opera Developer.