Jpx optimization

[p01]

20% faster JPX decoding

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/df1b3459ad8637a/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/5ed88af9a74f261/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/5ed88af9a74f261/output.txt

Total script time: 21.72 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/5ed88af9a74f261/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Linux)

---

Failed

Full output at http://107.21.233.14:8877/df1b3459ad8637a/output.txt

Total script time: 25.49 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/df1b3459ad8637a/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

Based on the test results, this seems to undo the rendering improvements of "S2.pdf" from PR #4565.

[p01]

Snuffleupagus: I believe the breakage of "S2.pdf" is due to the little snafu in p01@fc9bc54#src-core-jpx-js-P72

[fkaelberer]

((y[j - 1] + y[j + 1] + 2) >> 2)

Sure, you're right.

I believe the breakage of "S2.pdf" is due to the little snafu in p01/pdf.js@fc9bc54#src-core-jpx-js-P72

S2 does not use reversible transform, so I guess it's something else.

[p01]

Thanks!
The problem I "reintroduced" with S2.pdf was very simple.

See the fix: p01@bebf202
n was now a float and I could not use a bit shift directly.

The color differences between this branch and master never exceed 1 shade now.

[p01]

Any chance to get a run from BOTIO ? I don't want to block @fkaelberer 's work on memory optimizations too long

[timvandermeij]

Sure! Here we go.

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/8547801c61157dd/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/de5d306cf44a297/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/8547801c61157dd/output.txt

Total script time: 21.90 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/8547801c61157dd/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Linux)

---

Failed

Full output at http://107.21.233.14:8877/de5d306cf44a297/output.txt

Total script time: 25.81 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/de5d306cf44a297/reftest-analyzer.html#web=eq.log

[p01]

Thanks, this seems as expected: no more than 1 shade difference.

[yurydelendik]

/botio makeref

Really nice! Thank you for the patch

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/95a922d2880f051/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/75736254ec535a6/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/75736254ec535a6/output.txt

Total script time: 22.24 mins

• Lint: Ignored
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/95a922d2880f051/output.txt

Total script time: 25.90 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed