Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes custom test/reporter.js from the lint process #4577

Merged
merged 9 commits into from
Apr 11, 2014

Conversation

timvandermeij
Copy link
Contributor

Fixes #4544 and makes lint work on the Windows bot.

  • Resolves lint warnings W004 and W018 that were previously ignored.
  • Removes custom test/reporter.js from the lint process.

When this PR lands, we must configure the Windows bot to not ignore lint results anymore.

@yurydelendik
Copy link
Contributor

I think now make.js is cutting the output. Could you try not to call exit at https://github.com/mozilla/pdf.js/pull/4577/files#diff-da55c948ab565ebe30a2027fe5b721abR1295 ?

@timvandermeij timvandermeij changed the title Removes custom test/reporter.js from the lint process Removes custom test/reporter.js from the lint process [WIP] Apr 9, 2014
@timvandermeij timvandermeij changed the title Removes custom test/reporter.js from the lint process [WIP] Removes custom test/reporter.js from the lint process Apr 9, 2014
@timvandermeij timvandermeij changed the title Removes custom test/reporter.js from the lint process Removes custom test/reporter.js from the lint process [WIP] Apr 10, 2014
@timvandermeij timvandermeij changed the title Removes custom test/reporter.js from the lint process [WIP] Removes custom test/reporter.js from the lint process Apr 10, 2014
@timvandermeij
Copy link
Contributor Author

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/a4444b68b15e719/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/674b61393ca9323/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/674b61393ca9323/output.txt

Total script time: 0.83 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/a4444b68b15e719/output.txt

Total script time: 1.18 mins

  • Lint: Passed

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/a27aba10aad92b9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/98aaec7d45f48dd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/98aaec7d45f48dd/output.txt

Total script time: 22.03 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/a27aba10aad92b9/output.txt

Total script time: 25.66 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/a27aba10aad92b9/reftest-analyzer.html#web=eq.log

yurydelendik added a commit that referenced this pull request Apr 11, 2014
Removes custom test/reporter.js from the lint process
@yurydelendik yurydelendik merged commit 2c61f60 into mozilla:master Apr 11, 2014
@yurydelendik
Copy link
Contributor

Thank you

@timvandermeij timvandermeij deleted the reporter branch April 11, 2014 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom test/reporter.js from the lint process
3 participants