Check that images have valid dimensions (issue 4575)

[Snuffleupagus]

Attempting to fix #4575.

[yurydelendik]

I think fix is okay, but we need to address unhandled exception as well. Can we forward it to the page promise somehow?

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c02cbba55769c9a/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/c02cbba55769c9a/output.txt

Total script time: 0.42 mins

Published

• Viewer: http://107.21.233.14:8877/c02cbba55769c9a/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/c02cbba55769c9a/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/c02cbba55769c9a/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.21.233.14:8877/c02cbba55769c9a/extensions/firefox/pdf.js.amo.xpi

[timvandermeij]

This would probably also solve four of the broken PDFs listed at http://bthorben.github.io/pdfRepo, namely:

• http://www.firmenpresse.de/pdf-pressinfo795805.pdf
• http://www.firmenpresse.de/pdf-pressinfo948093.pdf
• http://www.firmenpresse.de/pdf-pressinfo946232.pdf
• http://www.firmenpresse.de/pdf-pressinfo803206.pdf

[yurydelendik]

We probably need start adding load tests for broken PDFs if they start appearing in the files from different sources or sites. This one localized to the single publisher [1.3 FPDF 1.52 / HTML2FPDF >> http://html2fpdf.sf.net]

[yurydelendik]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/d265588a3e37d38/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ba1711e54adc534/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/d265588a3e37d38/output.txt

Total script time: 0.98 mins

• Font tests: FAILED
• Unit tests: FAILED
• Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/d265588a3e37d38/reftest-analyzer.html#web=eq.log

[yurydelendik]

/botio-windows test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c9487d3a6924e1f/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/c9487d3a6924e1f/output.txt

Total script time: 22.04 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/ba1711e54adc534/output.txt

Total script time: 25.70 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[yurydelendik]

Thanks