Print WebGL status in the console #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/f79df450bcdd0fe/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/f79df450bcdd0fe/output.txt Total script time: 0.48 mins Published
|
yurydelendik
added a commit
that referenced
this pull request
Apr 11, 2014
Print WebGL status in the console
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's possible to enable WebGL through a preference, I think it makes sense to indicate if WebGL is active when printing debug info in the console.
This will not only be be useful when debugging, but should also help when people are reporting rendering bugs. (Since asking a bug reporter to open the console and copy-paste the messages should be a lot easier, and less error prone, compared to asking them to also run e.g.
PDFJS.disableWebGLand copy-paste the result of that.)Edit: Can easily tested with
http://107.22.172.223:8877/f79df450bcdd0fe/web/viewer.html#webgl=true
http://107.22.172.223:8877/f79df450bcdd0fe/web/viewer.html#webgl=false