Work-around for filesystem:-URL bug #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit https://robwu.nl/pdfjs/filesystem-worker-bug.htm and follow the steps to verify that the extension works as intended with this patch.
|
The function at https://github.com/mozilla/pdf.js/pull/4598/files#diff-dd42e9b2d2a652b8e312efa567698aa6R1918 grew a lot. Could you add that to the ChromeCom or move into separate file? It will be easier to develop and lint. |
and also default to '' instead of DEFAULT_URL to avoid trying to load a non-existent file when no file has been specified.
|
@yurydelendik Done. I've kept the commit separate from the first commit to have a clear distinction between the feature and the refactor. |
yurydelendik
added a commit
that referenced
this pull request
Apr 11, 2014
Work-around for filesystem:-URL bug
|
Thank you |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4592.
Visit https://robwu.nl/pdfjs/filesystem-worker-bug.htm and follow the
steps to verify that the extension works as intended with this patch.