Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized JPX decoder ~6% faster #4600

Merged
merged 1 commit into from
Apr 22, 2014
Merged

Conversation

p01
Copy link
Contributor

@p01 p01 commented Apr 11, 2014

No description provided.

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/fb9dbfcb7fb0119/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f9c2dd5c7e56d10/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/f9c2dd5c7e56d10/output.txt

Total script time: 22.03 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/fb9dbfcb7fb0119/output.txt

Total script time: 25.95 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

travis is broken

/botio-linux lint

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_lint from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/756d03e3d15ac06/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/756d03e3d15ac06/output.txt

Total script time: 0.81 mins

  • Lint: FAILED

@yurydelendik
Copy link
Contributor

### Linting JS files
src/core/jpx.js: line 1799, col 12, 'j' is already defined.
src/core/jpx.js: line 1799, col 15, 'n' is already defined.
src/core/jpx.js: line 1813, col 18, 'next' is already defined.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/236841dcb1ef0f1/output.txt

@timvandermeij
Copy link
Contributor

@p01 Could you fix the lint issues and rebase the PR so it can be reviewed?

@p01
Copy link
Contributor Author

p01 commented Apr 16, 2014

no problem. I'll do that first thing when I get back to work after the Easter break.

@p01
Copy link
Contributor Author

p01 commented Apr 22, 2014

Done.

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/22cecd3d0acfb34/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/54a85b156dc1656/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/54a85b156dc1656/output.txt

Total script time: 22.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/22cecd3d0acfb34/output.txt

Total script time: 25.83 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request Apr 22, 2014
Optimized JPX decoder ~6% faster
@yurydelendik yurydelendik merged commit ead4cbf into mozilla:master Apr 22, 2014
@yurydelendik
Copy link
Contributor

Looks good. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants