Refactors buildImage to use Promise; don't draw bad images #4613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yurydelendik
commented
Apr 13, 2014
yurydelendik
commented
- Removes LegacyPromise from image.js
- More generic case for Uncaught NotSupportedError #4575 type of exception
- Allows bad images to be skipped in canvas.js
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.21.233.14:8877/c7e49bbe97b0e62/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.22.172.223:8877/f0e6c8efb2c47e6/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/f0e6c8efb2c47e6/output.txt Total script time: 21.97 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c7e49bbe97b0e62/output.txt Total script time: 25.71 mins
|
| @@ -147,44 +151,40 @@ var PDFImage = (function PDFImageClosure() { | |||
| * Handles processing of image data and calls the callback with an argument | |||
There was a problem hiding this comment.
Please update the comment, since the callback is removed.
yurydelendik
added a commit
that referenced
this pull request
Apr 14, 2014
Refactors buildImage to use Promise; don't draw bad images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.