Refactoring - remove duplicated code in TextLayerBuilder #4618
Conversation
Not sure what do you mean by that. As I can see /botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/491931bb219929a/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/491931bb219929a/output.txt Total script time: 0.60 mins Published
|
| return; | ||
| } | ||
| div.appendChild(node); | ||
| appendText({offset: 0, divIdx: divIdx}, begin, className); |
There was a problem hiding this comment.
Hmm, new object creation... could you switch offset and divIdx places to have the same shape, i.e. {divIdx: divIdx, offset: 0}?
|
No preference |
|
squashed commits |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6a72df6a44b1773/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6a72df6a44b1773/output.txt Total script time: 0.37 mins Published
|
|
Really good. Thanks |
Refactoring - remove duplicated code in TextLayerBuilder
beginText() and appendText() in TextLayerBuilder.renderMatches() are identical except for adding an additional css class 'selected', which is superfluous anyway (callers that supply className already do that).