Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename getUint32 to getInt32 and collect readInt*() in util.js #4636

Merged
merged 1 commit into from
Apr 16, 2014

Conversation

fkaelberer
Copy link
Contributor

Fixes #4553 and collects duplicate readInt[16|32] functions in util.js.

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f6e8e2ce1e93d65/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/514239ffd5a988e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/f6e8e2ce1e93d65/output.txt

Total script time: 22.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/514239ffd5a988e/output.txt

Total script time: 25.89 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request Apr 16, 2014
Rename getUint32 to getInt32 and collect readInt*() in util.js
@yurydelendik yurydelendik merged commit eb554a8 into mozilla:master Apr 16, 2014
@yurydelendik
Copy link
Contributor

Thanks

@fkaelberer fkaelberer deleted the issue4553 branch April 21, 2014 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*Stream_getUint32() should be renamed to getInt32 or return unsigned Ints
3 participants