Only handle scroll events when PDFView.pdfDocument is defined (issue 4642) #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e32dfcd6388f63a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e32dfcd6388f63a/output.txt Total script time: 0.37 mins Published
|
|
@Snuffleupagus It does indeed fix it. |
yurydelendik
added a commit
that referenced
this pull request
Apr 24, 2014
Only handle scroll events when PDFView.pdfDocument is defined (issue 4642)
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted workaround to fix #4642. This should work, and it's a very easy solution, but I'm not completely convinced that this is the best way to handle the issue.
Edit: The reason for my apprehension about it, is that the patch adds code that is unnecessary most of the time to a function that is called a lot.
@dferer Does this fix the issue?