Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corrupted images #4649 #4653

Merged
merged 1 commit into from
Apr 21, 2014
Merged

Conversation

fkaelberer
Copy link
Contributor

Adds support for CMYK multiple component transform and so fixes #4649.

Sorry for that bug. I thought I had read in the JPEG2000 draft that multiple component transform only applies to 3 component images, but I got that wrong.
Additionally, according to the PDF 1.7 spec, page 89, 4 color images should be interpreted as CMYK unless specified otherwise.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/81a2597c85980af/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/a053f6930c6095e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0d14e57edcd7644/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/0d14e57edcd7644/output.txt

Total script time: 22.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/a053f6930c6095e/output.txt

Total script time: 25.79 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

JPEG2000 non-draft has only "The ICT [Irreversible multiple component transformation] is a decorrelating transformation applied to the first three components of an image" and "If a multiple component transform is specified within the codestream, the image must be in an RGB colourspace and the red, green and blue colours as channels 0, 1 and 2 in the codestream, respectively.". It's a little bit confusing, yes. Anyway, I agree with the change. Thank you for the patch.

yurydelendik added a commit that referenced this pull request Apr 21, 2014
@yurydelendik yurydelendik merged commit 5db157d into mozilla:master Apr 21, 2014
@fkaelberer fkaelberer deleted the issue4649 branch April 21, 2014 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted images
4 participants