Remove LegacyPromise in src/core/worker.js #4728
Conversation
| passwordChanged: function BasePdfManager_passwordChanged() { | ||
| this._passwordChangedCapability = createPromiseCapability(); | ||
| return this._passwordChangedCapability.promise; | ||
| }, |
There was a problem hiding this comment.
I'm okay with this change.
|
looks good |
Snuffleupagus
changed the title
|
Re-based and squashed. |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 2 Live output at: http://107.22.172.223:8877/8b62435b88c43cc/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 2 Live output at: http://107.21.233.14:8877/02b43eb24d8dece/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/8b62435b88c43cc/output.txt Total script time: 21.80 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/02b43eb24d8dece/output.txt Total script time: 25.64 mins
|
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/be70710f88bf7d4/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/be70710f88bf7d4/output.txt Total script time: 0.49 mins Published
|
…er.js Remove LegacyPromise in src/core/worker.js
|
Thank you for the patch |
Depends on PR #4725.
I wasn't sure what to make of #4430 (comment), so thus far this PR just replaces the Promises.
Another slight issue that I came across is the way that incorrect passwords are currently handled (see worker.js#L256-L257 and pdf_manager.js#L70-L72). We basically reach into the
pdfManagerobject and create a promise there, which seem all kinds of wrong :-)I've attempted to rectify this situation, and the patch does work, but I'm not sure if this is the best solution.
I will squash the commits once this is ready to be merged.