Refactors MessageHandler.send to remove callbacks #4752
Conversation
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/bf1b2866083d885/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7cd4bd524872938/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/7cd4bd524872938/output.txt Total script time: 23.62 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/bf1b2866083d885/output.txt Total script time: 25.72 mins
|
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/6c64a315d1576ca/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/07cc8b28ffac102/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/07cc8b28ffac102/output.txt Total script time: 0.73 mins Published
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/6c64a315d1576ca/output.txt Total script time: 23.22 mins
|
| * @param {String} actionName Action to call. | ||
| * @param {JSON} data JSON data to send. | ||
| * @param {Array} [transfers] Optional list of transfers/ArrayBuffers. | ||
| * @param {boolean} withPromise true if response if expected. |
There was a problem hiding this comment.
This parameter isn't used anywhere.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/987cf4b7c73dac5/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/987cf4b7c73dac5/output.txt Total script time: 0.71 mins Published
|
| ); | ||
| }.bind(this)); | ||
| return this.transport.messageHandler.sendWithPromise('GetTextContent', { | ||
| pageIndex: this.pageNumber - 1 |
There was a problem hiding this comment.
Should we change this to pageIndex: this.pageIndex instead?
Edit: Just asking, I don't really care either way.
Refactors MessageHandler.send to remove callbacks
|
Looks good; thank you! |
No description provided.