Add getFindBar for Fx extension #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7a5a594e03e650a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/7a5a594e03e650a/output.txt Total script time: 0.73 mins Published
|
| @@ -47,6 +47,11 @@ function runTests(document, window, callback) { | |||
| ok('PDFJS' in window.wrappedJSObject, "window content has PDFJS object"); | |||
|
|
|||
| // | |||
| // Browser Find | |||
| // | |||
| ok(gBrowser.isFindBarInitialized(tab), "Browser FindBar initialized!"); | |||
There was a problem hiding this comment.
chrome-browser test timeout due to this line
There was a problem hiding this comment.
Console message: [JavaScript Error: "tab is not defined" {file: "chrome://mochitests/content/browser/browser/extensions/pdfjs/test/browser_pdfjs_main.js" line: 52}]
|
@hobophobe thank you for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BMO: 1006714: 'Find' fails to search whole PDF with pdf.js when opened in a new tab was caused by BMO: 537013: The find bar should exist on a per-tab basis which made
gFindBarpoint to the active tab's findbar.This pull request addresses the defect by adding a function to get the correct findbar based on the
domWindow. It also adds a test that checks if the findbar has been initialized (I verified that the test fails pre-patch and passes post-patch, in addition to testing that the behavior described in the bug is fixed).