Adds Promises to getOperatorList #4770
Conversation
|
|
||
| for (var i = 0; i < gsState.length; i++) { |
There was a problem hiding this comment.
Probably a bug here in the master code
There was a problem hiding this comment.
I agree; the new code looks good.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/765ee3f21bda9af/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/765ee3f21bda9af/output.txt Total script time: 0.88 mins Published
|
|
This seems like a great idea! |
| var patternName = args[args.length - 1]; | ||
| // SCN/scn applies patterns along with normal colors | ||
| var pattern; | ||
| if (isName(patternName) && | ||
| (pattern = patterns.get(patternName.name))) { |
There was a problem hiding this comment.
Nit: the indentation is off.
yurydelendik
changed the title
|
/botio test ready for review |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.21.233.14:8877/5bdcb198a36ae52/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.22.172.223:8877/d2c20ea3a3782ed/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d2c20ea3a3782ed/output.txt Total script time: 24.96 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5bdcb198a36ae52/output.txt Total script time: 26.93 mins
|
Adds Promises to getOperatorList
|
Looks really good, thanks for the patch! |
|
I think this patch made great difference for my problematic PDF file in #4627 |
During active scrolling only one page can be parsed. This PR:
This allows parsing and display several pages at once (see https://gist.github.com/yurydelendik/513e6d9592fc4fd3a520)
This might help change people's perception of the performance when they actively scrolling.